xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant
rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r340428896
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/SortRemoveConstantKeysRule.java
##########
@@ -44,7 +45,7 @@
private SortRemoveConstantKeysRule() {
Review comment:
I am confident that the rules I update here will not cause the change of
search space, aka the transformation on physical nodes would result in an
equivalent, so it's safe. But we need to be careful when updating other rules.
And it'd better be done by the rule author. This change would solve most, if
not all, the problems, and we can always come back to update other rules when
feel necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
