xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant
rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r350990730
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/SortRemoveConstantKeysRule.java
##########
@@ -44,7 +45,7 @@
private SortRemoveConstantKeysRule() {
super(
- operand(Sort.class, any()),
+ operand(LogicalSort.class, any()),
Review comment:
Thanks for pointing this out. I am working on a revision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
