xndai commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes URL: https://github.com/apache/calcite/pull/1543#discussion_r346563987
########## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java ########## @@ -60,7 +62,7 @@ * {@link org.apache.calcite.rel.core.Correlate} from being de-correlated. */ public static final FilterProjectTransposeRule INSTANCE = - new FilterProjectTransposeRule(Filter.class, Project.class, true, true, + new FilterProjectTransposeRule(LogicalFilter.class, LogicalProject.class, true, true, Review comment: This is a good idea. I will try that. Thanks @rubenada ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services