danny0405 commented on a change in pull request #1568: [CALCITE-3486] In JDBC
adapter, when generating ROW value expression, generates the ROW keyword only
if the dialect allows it (quxiucheng)
URL: https://github.com/apache/calcite/pull/1568#discussion_r344543310
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java
##########
@@ -179,6 +179,9 @@ public boolean supportsAliasedValues() {
unparseFloor(writer, call);
break;
+ case ROW:
+ unparseRow(writer, call);
Review comment:
`XxxSqlDialect.DEFAULT` also works, if we have set up the `DatabaseProduct`
correctly. There is no overridden of method `SqlDialect#getConformance`, so i
believe the behavior is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
