danny0405 commented on a change in pull request #1568: [CALCITE-3486] In JDBC
adapter, when generating ROW value expression, generates the ROW keyword only
if the dialect allows it (quxiucheng)
URL: https://github.com/apache/calcite/pull/1568#discussion_r345169557
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlRowOperator.java
##########
@@ -82,7 +82,7 @@ public void unparse(
SqlCall call,
int leftPrec,
int rightPrec) {
- SqlUtil.unparseFunctionSyntax(this, writer, call);
+ writer.getDialect().unparseRow(writer, call, leftPrec, rightPrec);
}
Review comment:
We should not modify the unparse logic of `SqlRowOperator`, instead in
`SqlDialect`, match the `ROW` call and unparse it specifically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
