danny0405 commented on a change in pull request #1568: [CALCITE-3486] In JDBC adapter, when generating ROW value expression, generates the ROW keyword only if the dialect allows it (quxiucheng) URL: https://github.com/apache/calcite/pull/1568#discussion_r344986175
########## File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java ########## @@ -158,6 +158,7 @@ private final Casing unquotedCasing; private final Casing quotedCasing; private final boolean caseSensitive; + private final boolean allowExplicitRowValueConstructor; Review comment: Remove this `allowExplicitRowValueConstructor` flag, we expect to get this info from the `SqlConformance`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
