vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify:
eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r353450464
##########
File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java
##########
@@ -1740,6 +1731,19 @@ private void checkExponentialCnf(int n) {
"true");
}
+ @Test public void testSimplifyItemRangeTerms() {
+ RexNode item = item(input(tArray(tInt()), 3), literal(1));
+ simplify = this.simplify.withParanoid(false);
Review comment:
What is the point of this line?
If it is not required please remove it. If it is required please add a
clarification comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
