vlsi commented on a change in pull request #1610: [CALCITE-3525] RexSimplify:
eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r357932277
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
##########
@@ -142,21 +137,24 @@ protected FilterProjectTransposeRule(
public void onMatch(RelOptRuleCall call) {
final Filter filter = call.rel(0);
final Project project = call.rel(1);
+ final RelBuilder relBuilder = call.builder();
+ final RelNode newFilterRel = createNewFilterBelowProject(filter, project,
relBuilder);
- if (RexOver.containsOver(project.getProjects(), null)) {
Review comment:
This check could probably be moved to `matches(...)` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
