XuQianJin-Stars commented on a change in pull request #1681: [CALCITE-3601]
Update elasticsearch tests upgrade from junit4 to junit5
URL: https://github.com/apache/calcite/pull/1681#discussion_r360699211
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/EmbeddedElasticsearchPolicy.java
##########
@@ -104,7 +98,7 @@ public static EmbeddedElasticsearchPolicy create() {
* }
* </pre>
*
- * @param index index of the index
+ * @param index index of the index
Review comment:
> Please refrain from aligning parameter descriptions.
> It creates lots of unrelated changes, and it is prone to merge conflicts
in the future.
>
> See sample reasoning (~ `it creates problems for future maintenance` ):
https://google.github.io/styleguide/javaguide.html#s4.6.3-horizontal-alignment
well, Let me change it. There is something wrong with my code style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
