XuQianJin-Stars commented on a change in pull request #1681: [CALCITE-3601]
Update elasticsearch tests upgrade from junit4 to junit5
URL: https://github.com/apache/calcite/pull/1681#discussion_r360701660
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/EmbeddedElasticsearchPolicy.java
##########
@@ -216,4 +209,11 @@ private TransportAddress httpAddress() {
return node.httpAddress();
}
+ @Override public void afterAll(ExtensionContext context) throws Exception {
Review comment:
> No, I just had no idea how to approach the test.
>
> The approach you use seems to be nice. I have not checked TestContainer
best practices yet. They have a case for "keeping test container up for
multiple test classes", so there might be something to learn from.
I am also interested in learning about "keeping test container up for
multiple test classes".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
