XuQianJin-Stars commented on a change in pull request #1681: [CALCITE-3601]
Update elasticsearch tests upgrade from junit4 to junit5
URL: https://github.com/apache/calcite/pull/1681#discussion_r360702683
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/EmbeddedElasticsearchPolicy.java
##########
@@ -216,4 +209,11 @@ private TransportAddress httpAddress() {
return node.httpAddress();
}
+ @Override public void afterAll(ExtensionContext context) throws Exception {
Review comment:
> It looks like JUnit provides no solution yet, so TestContainers use their
own:
https://github.com/testcontainers/testcontainers-java/pull/887/files#diff-0dcf4d2cadeb3e526020477bc12e1420R73
Well, indeed, TestContainers also looks good. Thank you very much for
letting me learn something new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
