amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add
TIME/TIMESTAMP WITH TIME ZONE in optimizer
URL: https://github.com/apache/calcite/pull/1687#discussion_r361257782
##########
File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java
##########
@@ -1345,6 +1384,10 @@ private static Comparable zeroValue(RelDataType type) {
return new TimeString(0, 0, 0);
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
return new TimestampString(0, 0, 0, 0, 0, 0);
+ case TIME_WITH_TIME_ZONE:
+ return new TimeWithTimeZoneString(0, 0, 0, "UTC");
+ case TIMESTAMP_WITH_TIME_ZONE:
+ return new TimestampWithTimeZoneString(0, 0, 0, 0, 0, 0, "UTC");
Review comment:
Shouldn't 0 is `January 1, 1970 UTC`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
