docete commented on a change in pull request #1687: [CALCITE-3612] Add
TIME/TIMESTAMP WITH TIME ZONE in optimizer
URL: https://github.com/apache/calcite/pull/1687#discussion_r361268633
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -571,6 +323,457 @@ Expression translateCast(
return scaleIntervalToNumber(sourceType, targetType, convert);
}
+ private Expression converterToDate(RelDataType sourceType, Expression
operand) {
Review comment:
The aim of the refactoring is make sure the length of a method is smaller
than 370, and avoid complaining by checkstyle. I will split the refactoring
part to a separate commit, that would clarify the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
