amaliujia commented on a change in pull request #1687: [CALCITE-3612] Add
TIME/TIMESTAMP WITH TIME ZONE in optimizer
URL: https://github.com/apache/calcite/pull/1687#discussion_r361256059
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -571,6 +323,457 @@ Expression translateCast(
return scaleIntervalToNumber(sourceType, targetType, convert);
}
+ private Expression converterToDate(RelDataType sourceType, Expression
operand) {
Review comment:
I would prefer to split this refactoring with adding the new types into two
PRs, as it will make clear what is added by this PR and what is newly added
code. By doing so we could better review the new code.
Let's see what are other reviewers' opinions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
