danny0405 commented on a change in pull request #1710: [CALCITE-2672]
Qualifying the common column should not be allowed in Oracle dialect
URL: https://github.com/apache/calcite/pull/1710#discussion_r362182001
##########
File path:
core/src/main/java/org/apache/calcite/materialize/LatticeSuggester.java
##########
@@ -334,7 +334,7 @@ private Lattice findMatch(final Lattice lattice,
MutableNode mutableNode) {
}
if (bestMatch != null) {
- // Fix up the best batch
+ // Fix up the best match
for (Path path
Review comment:
There is already a fix there, remove this change or keep credit for the
contributor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
