chunweilei commented on a change in pull request #1710: [CALCITE-2672]
Qualifying the common column should not be allowed in Oracle dialect
URL: https://github.com/apache/calcite/pull/1710#discussion_r363175217
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java
##########
@@ -314,4 +314,18 @@ public boolean allowExtendedTrim() {
}
}
+ @Override public boolean allowQualifyingCommonColumn() {
+ switch (this) {
+ case ORACLE_10:
+ case ORACLE_12:
+ case STRICT_92:
+ case STRICT_99:
+ case STRICT_2003:
+ return false;
Review comment:
SQL standard also disallows qualifying the common columns[1].
[1] https://dev.mysql.com/doc/refman/8.0/en/join.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
