yanlin-Lynn commented on a change in pull request #1710: [CALCITE-2672]
Qualifying the common column should not be allowed in Oracle dialect
URL: https://github.com/apache/calcite/pull/1710#discussion_r362192559
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -5623,6 +5623,33 @@ private void checkNegWindow(String s, String msg) {
sql("select * from dept where exists (\n"
+ "select 1 from emp join bonus using (^deptno^))")
.fails("Column 'DEPTNO' not found in any table");
+
+ // cannot qualify common column in Oracle.
+ sql("select ^emp.deptno^ from emp join dept using (deptno)")
+ .withConformance(SqlConformanceEnum.ORACLE_10)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'")
+ .withConformance(SqlConformanceEnum.ORACLE_12)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'");
+
+ sql("select ^emp.deptno^ from emp natural join dept")
+ .withConformance(SqlConformanceEnum.ORACLE_10)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'");
+
+ sql("select ^emp.deptno^ from emp natural join dept")
+ .withConformance(SqlConformanceEnum.ORACLE_10)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'")
+ .withConformance(SqlConformanceEnum.ORACLE_12)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'");
+
+ sql("select count(^emp.deptno^) from emp join dept using (deptno)")
+ .withConformance(SqlConformanceEnum.ORACLE_10)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'")
+ .withConformance(SqlConformanceEnum.ORACLE_12)
+ .fails("Cannot qualify common column 'EMP.DEPTNO'");
+
+ sql("select emp.deptno from emp join dept using (deptno)")
+ .withConformance(SqlConformanceEnum.DEFAULT)
+ .ok();
Review comment:
can you add case for non common column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
