dhirenda-gautam opened a new pull request #1714: [Calcite 3663] Support for TRIM function in BigQuery dialect URL: https://github.com/apache/calcite/pull/1714 In current Calcite implementation for query : SELECT TRIM('ABC') for big-query Dialect it translated into SELECT TRIM(BOTH ' ' FROM 'ABC') . But the appropriate query for BigQuery is :: SELECT TRIM('ABC') Similarly below query SELECT TRIM(BOTH 'a' from 'ABC') SELECT TRIM(LEADING ' ' from 'ABC') SELECT TRIM(TRAILING ' ' from 'ABC') are translated into invalid BigQuery query. Unparse logic for the trim has been handle in BigQuery dialect to convert the source Trim query into valid bigQuery query.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
