amaliujia commented on a change in pull request #1714: [Calcite 3663] Support
for TRIM function in BigQuery dialect
URL: https://github.com/apache/calcite/pull/1714#discussion_r362580437
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -958,36 +958,82 @@ private static String toSql(RelNode root, SqlDialect
dialect) {
* <a
href="https://issues.apache.org/jira/browse/CALCITE-3220";>[CALCITE-3220]
* HiveSqlDialect should transform the SQL-standard TRIM function to TRIM,
* LTRIM or RTRIM</a>. */
- @Test public void testHiveTrim() {
+ @Test public void testHiveAndBqTrim() {
Review comment:
As you can see there is a comment about this test case which is hive
related. So you can also add comments for BQ.
You can either add another comment for BQ, or split this test case to hive
and BQ and then add comments seperately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
