dhirenda-gautam commented on a change in pull request #1714: [Calcite 3663]
Support for TRIM function in BigQuery dialect
URL: https://github.com/apache/calcite/pull/1714#discussion_r362836648
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -958,36 +958,82 @@ private static String toSql(RelNode root, SqlDialect
dialect) {
* <a
href="https://issues.apache.org/jira/browse/CALCITE-3220";>[CALCITE-3220]
* HiveSqlDialect should transform the SQL-standard TRIM function to TRIM,
* LTRIM or RTRIM</a>. */
- @Test public void testHiveTrim() {
+ @Test public void testHiveAndBqTrim() {
Review comment:
@amaliujia I have remove this check as this is an unnessary check over here
because in SqlTrimFunction class checkOperandTypes method perform the Operands
check.
Removed this assert as the operands type check is already done in
SqlTrimFunction class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
