danny0405 commented on issue #1738: [CALCITE-3719] Add hint option checker to customize the option URL: https://github.com/apache/calcite/pull/1738#issuecomment-572828858 > Hi, Danny, LGTM overall. > And just some thoughts, IMO, hint strategy is some kind of a `validation`, so I'm wondering if we can squash these two interface into one? I would rather keep the 2 interfaces for 3 reasons: 1. Now the `HintStrategy` can be used to multiple hints, i.e. the `NodeTypeHintStrategy`, but the `HintOptionChecker` is always used to a specific hint 2. The `HintOptionChecker` is optional 3. They can be used as functional interface, write as lambda `(rel, hint) ->`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
