vlsi commented on a change in pull request #1738: [CALCITE-3719] Add hint
option checker to customize the option
URL: https://github.com/apache/calcite/pull/1738#discussion_r365112920
##########
File path: core/build.gradle.kts
##########
@@ -78,7 +78,7 @@ dependencies {
testImplementation(kotlin("stdlib-jdk8"))
testImplementation(kotlin("test"))
testImplementation(kotlin("test-junit5"))
- testRuntimeOnly("org.slf4j:slf4j-log4j12")
+ testImplementation("org.slf4j:slf4j-log4j12")
Review comment:
In any case you don't really need `slf4j-log4j12` on the compilation
classpath.
You don't really reference slf4j-log4j12 classes.
You reference log4j12 classes.
I see the following options:
a) Keep `slf4j-log4j12` runtime-only and add an extra
`testImplementation("log4j:log4j") { because("SqlHintsConverterTest needs to
implement a MockAppender") }`
b) Create an extra `src/test-logging` folder that would have extra
dependency for testing logging behavior. For instance, `slf4j-test` or
`spf4j-slf4j-test` which are `slf4j` implementations designed to be used for
testing logging behaviors.
Then all the tests that do need to verify logging can be placed there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
