vlsi commented on a change in pull request #1738: [CALCITE-3719] Add hint
option checker to customize the option
URL: https://github.com/apache/calcite/pull/1738#discussion_r365098625
##########
File path: core/build.gradle.kts
##########
@@ -78,7 +78,7 @@ dependencies {
testImplementation(kotlin("stdlib-jdk8"))
testImplementation(kotlin("test"))
testImplementation(kotlin("test-junit5"))
- testRuntimeOnly("org.slf4j:slf4j-log4j12")
+ testImplementation("org.slf4j:slf4j-log4j12")
Review comment:
Why is this change?
The issue is it makes log4j APIs accessible in the testing code, so the
wrong `Logger` class appears in the auto-complete :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
