my7ym commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r392326029
##########
File path:
core/src/test/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java
##########
@@ -155,6 +155,8 @@ public MockCatalogReaderSimple(RelDataTypeFactory
typeFactory,
deptNestedTable.addColumn("NAME", fixture.varchar10Type);
deptNestedTable.addColumn("SKILL", fixture.skillRecordType);
deptNestedTable.addColumn("EMPLOYEES", fixture.empListType);
+ deptNestedTable.addColumn("ADMINS", fixture.varchar5ArrayType);
+ deptNestedTable.addColumn("OFFICES",
fixture.rectilinearPeekCoordMultisetType);
Review comment:
I am really confused about your review.
What do you mean by
> You should add a new nested StructKind.PEEK_FIELDS type and write test
with that.
Right now you again think we should create a new table/schema to avoid it. I
guess it's expected for you to know that this table is used in a lot of places.
Maybe I am wrong here?
And what's the drawbacks of so? It's test fixtures and should be shared with
multiple tests. Do we need to create a new test fixtures for every PR if it
changes other test assertions?
If you insist, please think it again and let me know if I create another
table with something like
` deptNestedExtended.addColumn("NAME", fixture.varchar10Type);
deptNestedExtended.addColumn("ADMINS", fixture.varchar5ArrayType);
deptNestedExtended.addColumn("EMPLOYEES", fixture.empListType);
deptNestedExtended.addColumn("OFFICES",
fixture.rectilinearPeekCoordMultisetType);
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
