danny0405 commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r392535735
##########
File path:
core/src/test/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java
##########
@@ -155,6 +155,8 @@ public MockCatalogReaderSimple(RelDataTypeFactory
typeFactory,
deptNestedTable.addColumn("NAME", fixture.varchar10Type);
deptNestedTable.addColumn("SKILL", fixture.skillRecordType);
deptNestedTable.addColumn("EMPLOYEES", fixture.empListType);
+ deptNestedTable.addColumn("ADMINS", fixture.varchar5ArrayType);
+ deptNestedTable.addColumn("OFFICES",
fixture.rectilinearPeekCoordMultisetType);
Review comment:
-1 because we should never break existing test because of not relevant
change.
I don’t care if you reuse the test code base but at least let’s not break
other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
