my7ym commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r391388454
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlUnnestOperator.java
##########
@@ -97,6 +97,17 @@ public SqlUnnestOperator(boolean withOrdinality) {
return builder.build();
}
+ private boolean allowFlattenStruct(SqlOperatorBinding operatorBinding) {
+ if (!(operatorBinding instanceof SqlCallBinding)) {
Review comment:
Again, this is original behavior. I feel like for a PR, it could be better
to only contain all the relevant changes without changing existing behaviors
for irrelevant flows.
There are 8 other subclasses of `SqlOperatorBinding` and I guess several of
them should not be here. If you believe this is a serious issue and should be
addressed, we should have another refactor for it.
Let me know if you insist on gating the `RexCallBinding`, I will add another
commit to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
