hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance
issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399587559
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -1998,6 +1996,12 @@ public static void
registerAbstractRelationalRules(RelOptPlanner planner) {
// todo: rule which makes Project({OrdinalRef}) disappear
}
+ private static void registerEnumerableRelNodeFactories() {
+ RelBuilderFactory factory = RelFactories.LOGICAL_BUILDER;
+ factory.registerFactoriesWithConvention(EnumerableConvention.INSTANCE,
+ EnumerableRelFactories.DEFAULT_STRUCT);
Review comment:
To register a `relBuilderFactory`, we need a `LOGICAL_BUILDER`. This is a
little weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
