danny0405 commented on issue #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention URL: https://github.com/apache/calcite/pull/1884#issuecomment-605386017 I have opposite opinion for the direction, we should not modify the `RelBuilder` for a specific `convention`, `EnumerableConvention` is just a implementation of Calcite, how about the other conventions ? Like the `JdbcConvention` or other custom conventions. Basically, `RelBuilder` does nothing wrong with building logical nodes. We do not need to guide the users that we should care about the convention thing when building a relational expression. I agree we should find out the way to change the convention conventionally after building the tree, but let's make it a separate program/component that can be plugin in. Passing around the `RelBuilder` as a parameter seems too tricky for me, and some of the interface has both `trait` and `convention` as parameters, isn't the `convention` also a trait ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
