hsyuan commented on issue #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention URL: https://github.com/apache/calcite/pull/1884#issuecomment-605388894 Modifying `RelBuilder` is not for `EnumerableConvention` specifically, it is just an example here, other convention can also apply using the same way, as long as they can accept the same arguments. I agree that passing RelBuilder isn't ideal, we can remove that. But when we create the a physical sort operator for collation trait we have to know the corresponding convention, so that we can create the correct physical operator. Convention is a kind of trait, per Calcite's definition, but it is completely different with any other trait, it has so many special treatment. I even don't agree with the design that convention is a physical trait.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
