chunweilei commented on a change in pull request #1884: [CALCITE-2970]
Performance issue when enabling abstract converter for EnumerableConvention
URL: https://github.com/apache/calcite/pull/1884#discussion_r399901726
##########
File path: core/src/main/java/org/apache/calcite/plan/RelTraitDef.java
##########
@@ -115,14 +117,17 @@ assert getTraitClass().isInstance(trait)
* @param planner the planner requesting the conversion
* @param rel RelNode to convert
* @param toTrait RelTrait to convert to
+ * @param conventionTrait Target convention to convert to
* @param allowInfiniteCostConverters flag indicating whether infinite cost
* converters are allowed
* @return a converted RelNode or null if conversion is not possible
*/
public abstract RelNode convert(
RelOptPlanner planner,
+ RelBuilder builder,
RelNode rel,
T toTrait,
+ Convention conventionTrait,
boolean allowInfiniteCostConverters);
Review comment:
Is it a break change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
