xndai commented on a change in pull request #1910: [CALCITE-3915] Add rule
listener to report rule attempts and time at …
URL: https://github.com/apache/calcite/pull/1910#discussion_r407330555
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java
##########
@@ -196,7 +196,7 @@ VolcanoRuleMatch popMatch(VolcanoPlannerPhase phase) {
phaseMatchList.matchMap.remove(
planner.getSubset(match.rels[0]), match);
- LOGGER.debug("Pop match: {}", match);
+ LOGGER.trace("Pop match: {}", match);
return match;
Review comment:
Why not just discuss here? Right now there are just too many logs at DEBUG
level, including all the rule firing and transformations. I try to separate
DEBUG and TRACE so we could get the important ones when enable DEBUG, things
like the best plan, rules attempted, etc. Without the log level change, this PR
is not quite useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
