vlsi commented on a change in pull request #1910: [CALCITE-3915] Add rule
listener to report rule attempts and time at …
URL: https://github.com/apache/calcite/pull/1910#discussion_r409385050
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RuleQueue.java
##########
@@ -196,7 +196,7 @@ VolcanoRuleMatch popMatch(VolcanoPlannerPhase phase) {
phaseMatchList.matchMap.remove(
planner.getSubset(match.rels[0]), match);
- LOGGER.debug("Pop match: {}", match);
+ LOGGER.trace("Pop match: {}", match);
return match;
Review comment:
> Without the log level change, this PR is not quite useful.
@xndai , this is exactly why I suggest that we should use **categories**
rather than `log levels` to configure planner tracing.
What you add looks more like a standalone debugging feature rather than a
yet another logging level.
We should move heavyweight logging to their own categories otherwise we
never converge on what is debug and what is trace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
