xndai commented on a change in pull request #1910: [CALCITE-3915] Add rule
listener to report rule attempts and time at …
URL: https://github.com/apache/calcite/pull/1910#discussion_r407614640
##########
File path:
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
##########
@@ -96,6 +101,11 @@ protected AbstractRelOptPlanner(RelOptCostFactory
costFactory,
// these types, but some operands may use them.
classes.add(RelNode.class);
classes.add(RelSubset.class);
+
+ if (LOGGER.isDebugEnabled()) {
+ this.ruleAttemptsListener = new RuleAttemptsListener();
Review comment:
I don't think we need a separate category just for the rule attempts. IMO it
makes more sense to put them in DEBUG level log, together with the best plan
and provenance map. And the verbose rule firing and transformation messages
should really be TRACE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
