hsyuan commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r416298317
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -764,6 +764,13 @@ RelNode changeTraitsUsingConverters(
// will be left as is. Finally, any null entries in toTraits are
// ignored.
RelNode converted = rel;
+ Convention conventionTrait = null;
+ for (RelTrait trait : toTraits) {
+ if (trait instanceof Convention) {
+ conventionTrait = (Convention) trait;
+ break;
+ }
+ }
Review comment:
Can we use toTraits.getTrait() to get convention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
