hsyuan commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r416299380
##########
File path:
core/src/test/java/org/apache/calcite/plan/volcano/CollationConversionTest.java
##########
@@ -232,7 +232,7 @@ public RelCollation getDefault() {
}
public RelNode convert(RelOptPlanner planner, RelNode rel,
- RelCollation toCollation, boolean allowInfiniteCostConverters) {
+ RelCollation toCollation, Convention toConvention, boolean
allowInfiniteCostConverters) {
Review comment:
This is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
