F21 commented on pull request #50: URL: https://github.com/apache/calcite-avatica-go/pull/50#issuecomment-644520679
Hey thanks for implementing this. I have a question regarding the implementation. From what I can see this enables batching within a transaction, meaning that all changes within a transaction will not be executed on the server until a commit is issued. In this case, if we try to update some data and query it within a transaction, it will not work as expected. If this is the case I think batching should be added as a configuration flag and only explicitly enabled by the user. I don't think we need to commit the `docker-compose-cn.yml` file here as the alpine linux cdn should be accessible within china and it creates more work when it comes to updating the version numbers in the docker-compose file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
