F21 commented on pull request #50: URL: https://github.com/apache/calcite-avatica-go/pull/50#issuecomment-644639393
Looks great! Just a few small things: - Protect `batchUpdates` in statement with a mutex. This is because a statement should be safe to be used by multiple goroutines: https://golang.org/pkg/database/sql/#Stmt - Document the new parameter to turn on batching here: https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_client_reference.md#dsn-data-source-name - Add a test to test batching and make sure it works as expected. Please add one for Phoenix and one for HSQLDB. Once that's done: - Open a JIRA issue for this change at https://issues.apache.org/jira/projects/CALCITE/issues - Squash the commits and change the commit message to: `[CALCITE-XXXX] Your description here (your name here)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
