F21 commented on pull request #50: URL: https://github.com/apache/calcite-avatica-go/pull/50#issuecomment-644588919
Thanks for making those changes! I'll review them very shortly. I think the mutex for safety is a good addition. What I meant is that if we use batching the result will be unexpected if we query in a transaction: ``` --> begin transaction --> exec to update data --> query for changes // data does not appear to be updated --> exec to update some more data --> commit // changes are actually sent to the server ``` So, with batching enabled, any query response would not be up to date as the batched changes has not been sent to the server. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
