bsideup commented on a change in pull request #2223:
URL: https://github.com/apache/calcite/pull/2223#discussion_r507705443
##########
File path:
redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java
##########
@@ -36,16 +43,33 @@
public static final String HOST = "127.0.0.1";
private static final String MAX_HEAP = "maxheap 51200000";
+ // If Docker is running, a container will be used
+ public static final GenericContainer<?> REDIS_CONTAINER =
+ new GenericContainer<>("redis").withExposedPorts(6379);
Review comment:
consider using a fixed version image, for reproducible tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]