vlsi commented on a change in pull request #2223:
URL: https://github.com/apache/calcite/pull/2223#discussion_r515826195
##########
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##########
@@ -239,6 +239,12 @@
public static final CalciteSystemProperty<Boolean> TEST_REDIS =
booleanProperty("calcite.test.redis", true);
+ /**
+ * Whether to use Docker with TestContainers
(https://www.testcontainers.org/) when available
+ */
+ public static final CalciteSystemProperty<Boolean>
TEST_WITH_DOCKER_CONTAINER =
+ booleanProperty("calcite.test.docker", true);
+
Review comment:
@tgrall , would you please add a corresponding comment to the javadoc?
I believe the key point of having such a property is to allow running a
non-docker test even in the case Docker is installed on the developer's machine.
For instance, it might be helpful to replicate an issue that happens only in
non-docker test mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
