danny0405 commented on a change in pull request #2272:
URL: https://github.com/apache/calcite/pull/2272#discussion_r528690456
##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java
##########
@@ -79,6 +79,10 @@ protected RelDataTypeImpl() {
@Override public RelDataTypeField getField(String fieldName, boolean
caseSensitive,
boolean elideRecord) {
+ if (fieldList == null) {
+ throw new IllegalStateException("Requested field " + fieldName
+ + " in a type with null fieldList, type = " + this);
Review comment:
In which case, use can pass in a null fieldList ? I would rather to move
the check to the builder that generate the `RelDataTypeImpl` instance.
The exception message is also confusing, we should tell user why he does
wrong but not "we got null field list".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
