julianhyde commented on pull request #2272: URL: https://github.com/apache/calcite/pull/2272#issuecomment-733796356
No. You seem to have made a new rule “anyone who critiques a PR has to write code to fix it”. That’s not how it works. On Wed, Nov 25, 2020 at 7:58 AM Vladimir Sitnikov <[email protected]> wrote: > *@vlsi* commented on this pull request. > ------------------------------ > > In core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java > <https://github.com/apache/calcite/pull/2272#discussion_r530479592>: > > > @@ -79,6 +79,10 @@ protected RelDataTypeImpl() { > > @Override public RelDataTypeField getField(String fieldName, boolean caseSensitive, > boolean elideRecord) { > + if (fieldList == null) { > + throw new IllegalStateException("Requested field " + fieldName > + + " in a type with null fieldList, type = " + this); > > Please suggest exact pattern to insert into new IllegalStateException(...) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/calcite/pull/2272#discussion_r530479592>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAIUAOIUJYNEZQ3R736LZC3SRUSRBANCNFSM4T3TA5EQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
