julianhyde commented on a change in pull request #2272:
URL: https://github.com/apache/calcite/pull/2272#discussion_r530473402
##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java
##########
@@ -79,6 +79,10 @@ protected RelDataTypeImpl() {
@Override public RelDataTypeField getField(String fieldName, boolean
caseSensitive,
boolean elideRecord) {
+ if (fieldList == null) {
+ throw new IllegalStateException("Requested field " + fieldName
+ + " in a type with null fieldList, type = " + this);
Review comment:
My suggestion is meaningful, too.
The verbose message says that the type doesn’t support named field lookup.
So the reader will wonder whether it supports field lookup by other means. No,
it doesn’t have fields. Just say that.
A simple message is sufficient for the user to diagnose their problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
