danny0405 commented on pull request #2302: URL: https://github.com/apache/calcite/pull/2302#issuecomment-783232300
> @danny0405 this PR LGTM, and I think it does the trick solving the issue described in the Jira. > You have been working on the Decorrelator lately, so I would appreciate your feedback in here. If you are too busy and don't have time, no problem, I can take this PR and merge it myself. The additional variable `isCorVarDefined` did solve the problem, i like it. But i don't like the way it is passed around everywhere for each interface method. Can we promote to avoid that ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
