[GitHub] [calcite] danny0405 commented on a change in pull request #2302: [CALCITE-4437] The Sort rel should be decorrelated even though it has fetch or limit when it is not inside a Correlate (Thomas Rebele)

[GitBox]

danny0405 commented on a change in pull request #2302:
URL: https://github.com/apache/calcite/pull/2302#discussion_r580104993



##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -429,7 +430,7 @@ protected RexNode removeCorrelationExpr(
         ImmutableSortedMap.of());
   }
 
-  public @Nullable Frame decorrelateRel(Sort rel) {
+  public @Nullable Frame decorrelateRel(Sort rel, boolean isCorVarDefined) {
     //

Review comment:
       Is there other way to handle the `isCorVarDefined` variables ? For 
example, keep it as a internal state while decorrelating.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org