vlsi commented on a change in pull request #2488:
URL: https://github.com/apache/calcite/pull/2488#discussion_r689730188
##########
File path: build.gradle.kts
##########
@@ -71,6 +71,7 @@ val enableSpotBugs = props.bool("spotbugs")
val enableCheckerframework by props()
val enableErrorprone by props()
val enableDependencyAnalysis by props()
+val enableParameters by props(true)
Review comment:
The intention was enabled by default features were named `skip*` and
disabled by default were named `enable*`.
So I would suggest rephrasing the flag as `skipJavacParameterNames` or
something like that.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
