vlsi commented on a change in pull request #2488:
URL: https://github.com/apache/calcite/pull/2488#discussion_r690596413
##########
File path: build.gradle.kts
##########
@@ -71,10 +71,10 @@ val enableSpotBugs = props.bool("spotbugs")
val enableCheckerframework by props()
val enableErrorprone by props()
val enableDependencyAnalysis by props()
-val enableParameters by props(true)
val skipJandex by props()
val skipCheckstyle by props()
val skipAutostyle by props()
+val skipJavacParameterNames by props(true)
Review comment:
I would go with adding parameter names by default.
```suggestion
val skipJavacParameterNames by props()
```
##########
File path: build.gradle.kts
##########
@@ -693,7 +693,7 @@ allprojects {
if (enableCheckerframework) {
options.forkOptions.memoryMaximumSize = "2g"
}
- if (enableParameters) {
+ if (skipJavacParameterNames) {
Review comment:
```suggestion
if (!skipJavacParameterNames) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
