asolimando commented on a change in pull request #2488:
URL: https://github.com/apache/calcite/pull/2488#discussion_r690572316
##########
File path:
core/src/main/java/org/apache/calcite/adapter/java/ReflectiveSchema.java
##########
@@ -75,6 +78,8 @@
extends AbstractSchema {
private final Class clazz;
private final Object target;
+ private Types.FieldsOrdering fieldsOrdering;
+ private @Nullable Map<Class, List<Field>> classFieldsMap;
Review comment:
I was not familiar with the `ClassValue` interface, from what I
understood by looking it up, it looks beneficial when the `Map` could be the
only impediment to the disposal of classes by the GC.
I think I would anyway need to pass (via the constructor of `MyClassValue`)
and store a Map internally to implement the `computeValue` method, so it won’t
probably help much. I also expect the list of classes in the map to be of a
reasonable size, since it’s coming from the user.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
