vlsi commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r761972377
##########
File path:
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -673,7 +707,7 @@ LogicalProject(DEPTNO=[$7], EXPR$1=[$9])
</Resource>
<Resource name="planNotExpanded">
<![CDATA[
-LogicalProject(DEPTNO=[$7], EXPR$1=[$SCALAR_QUERY({
+LogicalProject(variablesSet=[[$cor0]], DEPTNO=[$7], EXPR$1=[$SCALAR_QUERY({
Review comment:
I believe we should change `variablesSet` to something more meaningful.
I think it won't be that disruptive for calcite users, so I would go with
the renames.
However, we can deal with Filter and other rels separately (to avoid mixing
different features in a single PR). I would leave it up to you (I would be fine
with both changing all at once for consistency, or changing in separate PR for
segregating unrelated changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
