vlsi commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r767802077
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalProject.java
##########
@@ -123,12 +143,27 @@ public static LogicalProject create(final RelNode input,
List<RelHint> hints,
cluster.traitSet().replace(Convention.NONE)
.replaceIfs(RelCollationTraitDef.INSTANCE,
() -> RelMdCollation.project(mq, input, projects));
- return new LogicalProject(cluster, traitSet, hints, input, projects,
rowType);
+ return new LogicalProject(cluster, traitSet, hints, input, projects,
rowType,
+ ImmutableSet.of());
+ }
Review comment:
Could you delegate to the new method instead of duplicating the logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
